XUnit Reporter Writes to stdout, falls back to console.log #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes mochajs#1674; provides support *much* needed for [mocha-phantomjs](https://github.com/nathanboktae/mocha-phantomjs) (see [mochajs#133](nathanboktae/mocha-phantomjs#133), [mochajs#220](nathanboktae/mocha-phantomjs#220), etc). Maintains support for running the XUnit reporter in a browser (unlike the previously reverted PR mochajs#1068). ping @alemangui, @nathanboktae Thanks all.
| @@ -109,6 +109,8 @@ XUnit.prototype.done = function(failures, fn) { | |||
| XUnit.prototype.write = function(line) { | |||
| if (this.fileStream) { | |||
| this.fileStream.write(line + '\n'); | |||
| } else if (typeof process === 'object' && typeof process.stdout === 'object') { | |||
There was a problem hiding this comment.
This would be better written as:
} else if (typeof process === 'object' && process.stdout) {
|
Comment aside, LGTM. Ideally, reporters wouldn't invoke console.log directly anyway, but instead be passed a writable stream to use. |
|
Updated based on feedback; merging this would be joy to |
danielstjules
added a commit
that referenced
this pull request
Dec 25, 2015
XUnit Reporter Writes to stdout, falls back to console.log
|
👍 🎅 Thanks! |
Yes this would be great and solve alot of magic done by plugins like |
nathanboktae
added a commit
to nathanboktae/mocha-phantomjs
that referenced
this pull request
Dec 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1674; provides support much needed for mocha-phantomjs (see #133, #220, etc). Maintains support for running the XUnit reporter in a browser (unlike the previously reverted PR #1068).
ping @alemangui, @nathanboktae
Thanks all.