make sure the xunit output dir exists before trying to write to it #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianwremmel
force-pushed
the
fix-xunit-hang
branch
from
4f8494a
to
1cc21a9
Compare
|
Can you take a look at the linting errors? |
|
Can you move that logic to |
|
I encountered the problem with grunt-mocha-test. Won't putting the fix in _mocha only help with command line usage while still leaving it broken for programmatic usage? |
|
Ah, you're right. Your current approach makes most sense anyway. Thanks! |
danielstjules
added a commit
that referenced
this pull request
Dec 9, 2015
make sure the xunit output dir exists before trying to write to it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.