🛠 Repo: New site isn't deployed to mochajs.org/next

[mark-wiemer]

Tooling Suggestion Checklist

• I have tried restarting my IDE and the issue persists.
• I have pulled the latest main branch of the repository.
• I have read and agree to Mocha's Code of Conduct and Contributing Guidelines
• I have searched for related issues and issues with the faq label, but none matched my issue.
• I want to provide a PR to resolve this

Overview

mochajs.org/next should host the new docs site

Additional Info

Build logic is hosted in Netlify, so most contributors can't help here :/

[mark-wiemer]

(I've been granted access and am poking around now, won't post screenshots as I'm new to Netlify and unsure what might be considered a security risk)

[mark-wiemer]

Netlify initializes its build environment by installing dependencies via corepack's pnpm. We developers were using the non-corepack npm to install. When using corepack's pnpm on my machine, I am able to reproduce the issue:

1. Get a fresh clone of the repo (make sure there are no node_modules installed or anything else)
2. Use Node v20 (that's what our Netlify uses, v20.19.0 currently)
3. npm i -g corepack@latest (ref Newly published versions of package managers distributed from npm cannot be installed due to key id mismatch nodejs/corepack#612)
4. cd docs-next
5. corepack enable
6. pnpm install (corepack will prompt you to install, accept the prompts. About corepack)
7. npm run docs

$ npm run docs
...
 generating static routes 
18:34:37 ▶ @astrojs/starlight/routes/static/404.astro
18:34:37   └─ /404.html (+29ms)
18:34:37 ▶ @astrojs/starlight/routes/static/index.astro
18:34:37   ├─ /declaring/dynamic-tests/index.html (+18ms)
...
18:34:38   ├─ /features/timeouts/index.html (+13ms)
18:34:38   ├─ /getting-started/index.htmlNamed export 'DecodingMode' not found. The requested module 'entities/lib/decode.js' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'entities/lib/decode.js';
const { EntityDecoder, htmlDecodeTree, DecodingMode } = pkg;

  Stack trace:
    at ModuleJob._instantiate (node:internal/modules/esm/module_job:134:21)
    at async ModuleLoader.import (node:internal/modules/esm/loader:316:24)
    at async file:///C:/Users/markw/my-stuff/mocha-stuff/mocha/docs-next/dist/chunks/common_DeJn9w_V.mjs:1086:33

$

Narrows down our issue a bit

[mark-wiemer]

pnpm ignores package-lock.json by default. I tried pnpm import on a clean install, no dice.

Likely the issue is that some dependency (root or transient) published an incompatible version recently, but we didn't notice when using npm because that didn't fetch the latest version. But pnpm doesn't see any relevant lock file, so it's fetching the latest "compatible" versions of all dependencies and something there breaks. Super wonky for sure!

[mark-wiemer]

Opened a question on Netlify Support Forum

[JoshuaKGoldberg]

🚀 Awesome find!

[mark-wiemer]

Unfortunately the Netlify "Production" deploy for this is still failing and trying to use pnpm, even though the
"Deploy Preview" responded as intended. So so strange. No update on the support forum

For maintenance crew reference:

• Failing Production deploy logs
• Successful Deploy Preview deploy logs

[mark-wiemer]

Using Netlify's GUI to add the env var NPM_VERSION as 10.8.1 for all deploys of mocha-docs-next worked on the Production deploy!

For maintenance crew reference:

• Successful Production deploy logs
• Site configuration GUI

For now I've deleted the value to test with setting it in our netlify.toml file. Note we have two such files in the repo ;)