feat(bin/options.js): Add support for comment lines in "mocha.opts"

Modified code to strip comment lines, those beginning with a hash character ('#'), from "mocha.opts" prior to processing its contents. Fixes #3370
mochajs · May 3, 2018 · a9745f1 · a9745f1
1 parent 8368722
commit a9745f1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/bin/options.js b/bin/options.js
@@ -32,6 +32,7 @@ function getOptions() {
   try {
     const opts = fs
       .readFileSync(optsPath, 'utf8')
+      .replace(/^#.*$/gm, '')
       .replace(/\\\s/g, '%20')
       .split(/\s/)
       .filter(Boolean)

diff --git a/test/integration/regression.spec.js b/test/integration/regression.spec.js
@@ -32,6 +32,7 @@ describe('regressions', function() {
     var processArgv = process.argv.join('');
     var mochaOpts = fs
       .readFileSync(path.join(__dirname, '..', 'mocha.opts'), 'utf-8')
+      .replace(/^#.*$/gm, '')
       .split(/[\s]+/)
       .join('');
     assert.notEqual(

diff --git a/test/mocha.opts b/test/mocha.opts
@@ -1,6 +1,11 @@
+###
+### mocha.opts
+###
+
 --require ./test/setup
 --ui bdd
 --globals okGlobalA,okGlobalB
 --globals okGlobalC
 --globals callback*
 --timeout 200
+