-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add Node.js v10 to build; fix win32 issues (#3350)
* fix npm version to 5.x * AppVeyor: add Node.js v10; use npm ci for speed * revert package-lock.json to what npm@5 uses * add .gitattributes * remove linebreak-style from eslintrc * avoid all symlink tests on win32 Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
- Loading branch information
Showing
6 changed files
with
6,206 additions
and
6,433 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,9 +16,6 @@ rules: | |
strict: | ||
- error | ||
- safe | ||
linebreak-style: | ||
- error | ||
- unix | ||
overrides: | ||
- files: | ||
- scripts/**/*.js | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
* text=auto |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
1224a48
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side comments only concerning "appveyor.yml":
If you have
shallow_clone
, thenclone_depth
ignored.Appears "CI" is set by AppVeyor. We resetting it to get lowercase value?
We should rename this file as ".appveyor.yml"