Skip to content

Conversation

djs55
Copy link
Collaborator

@djs55 djs55 commented Oct 7, 2022

Previously users would see network glitches every 2hrs as the lease was renewed.

Since vpnkit is used in "static" environments, we can offer very long leases. This value is in seconds and > 68 years.

Signed-off-by: David Scott dave@recoil.org

Previously users would see network glitches every 2hrs as the lease was
renewed.

Since vpnkit is used in "static" environments, we can offer long leases.

Unfortunately I couldn't specify an "infinite" lease: the value 0xffffffff
seems to get lost somewhere.

Signed-off-by: David Scott <dave@recoil.org>
@djs55 djs55 changed the title dhcp: offer infinite leases dhcp: offer very long leases Oct 22, 2022
Copy link
Collaborator

@avsm avsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DHCP does allow 0xffffffff to represent an infinite lease too, which might be a bit cleaner.

@djs55 djs55 merged commit de968b6 into moby:master Oct 22, 2022
@djs55 djs55 deleted the infinite-lease branch October 22, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants