Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Defer dockerRm until we are finished with the contents #193

Merged
merged 1 commit into from
Dec 13, 2017
Merged

Defer dockerRm until we are finished with the contents #193

merged 1 commit into from
Dec 13, 2017

Commits on Dec 13, 2017

  1. Defer dockerRm until we are finished with the contents 

    This was introduced by moby#191 but somehow did not trigger either for me in local
testing or in CI.

It did trigger in initial CI of linuxkit/linuxkit#2811
which can be seen at https://linuxkit.datakit.ci/linuxkit/linuxkit/pr/2811?history=1637690296123e9a15307b3a41b290da6e27e7cc
The error is:

    Failed to docker rm container «...»: «...»: aufs: unmount error after retries: «...»: device or resource busy

No doubt because we were still holding an open fd while trying to remove the
container.

Unclear why this didn't repro for me (docker 17.11.0-ce with overlay2) or
whatever CI uses.

Signed-off-by: Ian Campbell <ijc@docker.com>
    Ian Campbell committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    307f13b View commit details
    Browse the repository at this point in the history