Add support for devices #3186
Open
Add support for devices #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>
Signed-off-by: Zik Aeroh <48577114+zikaeroh@users.noreply.github.com>
olljanat
force-pushed
the
add-devices-support
branch
from
662ab0e to
606f702
Compare
|
@dperny @neersighted PTAL |
This was referenced Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Replacement for #3106 which passes CI.
- How I did it
Removed protocol parts from commit 8d68df6 and re-added it as new commit which does not cause merge conflicts.
Actual implementation is still from #3106
- How to test it
Should be fine when CI passes.
- Description for the changelog