vendor: github.com/docker/docker v23.0.0#3117
Conversation
|
@dperny @neersighted ptal |
|
@thaJeztah Can you rebase to fix the vcs issue? https://github.com/moby/swarmkit/actions/runs/4101962185/jobs/7074363750#step:5:11 |
thaJeztah
force-pushed
the
update_engine
branch
from
02601ff to
f7d6e66
Compare
|
👍 rebased (oh! probably need to remove some config to remove CircleCI - or do we need a dummy CircleCI config in master if we still need it in the bump_20.10 branch?) |
|
Yes we need to remove the GitHub App and associated webhooks in repo settings. Don't think we need a dummy CircleCI workflow as we don't have any branches that require CircleCI atm. |
|
We might still need the bump_20.10 branch. Can we backport GHA there? |
Oh didn't recall about this branch (sorry @thaJeztah, overlooked your comment). Backporting GHA would be not that trivial I think. It might make sense to keep a dummy CircleCI config on default branch in the meantime. |
- client: improve error messaging on crash full diff: moby/moby@v23.0.0-rc.3...v23.0.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
@neersighted @dperny this one should be ready for review now (CI is now green with the CircleCI fix) Also opened a follow-up (larger diff due to GinkGo update in that one, so kept it separate for now); #3124 |
|
Thanks! I'll bring this one in, and rebase the other one |
3 participants
full diff: moby/moby@v23.0.0-rc.3...v23.0.0
- Description for the changelog