Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: remove more replace rules #3094

Merged
merged 4 commits into from
Nov 23, 2022

Conversation

thaJeztah
Copy link
Member

go.mod: remove replace for google.golang.org/grpc

Moving the comment to warn people when updating.

go.mod: remove replace for github.com/golang/protobuf

it was no longer replacing anything

go.mod: remove replace for google.golang.org/protobuf

it was no longer replacing anything.

docker/docker is already on v1.28.0, and all looks to be working fine.

go.mod: google.golang.org/genproto v0.0.0-20210821163610-241b8fcbd6c8

remove replace for google.golang.org/genproto

full diff: googleapis/go-genproto@81c1377...241b8fc

go.mod: go.etcd.io/etcd/client/pkg/v3 v3.5.5

Moving the comment to warn people when updating.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
it was no longer replacing anything

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
it was no longer replacing anything.

docker/docker is already on v1.28.0, and all looks to be working fine.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
remove replace for google.golang.org/genproto

full diff: googleapis/go-genproto@81c1377...241b8fc

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

thaJeztah commented Nov 23, 2022

Looks like a flaky test? Some other parts of that test were disabled in #2137

time="2022-11-23T10:05:19Z" level=error msg="update failed" error="task kcpea42oo4wa6vb9xvqqyu4lb was already shut down when reached by updater (state: SHUTDOWN)" task.id=k9vzsok88psz952rlf8h0ims5
time="2022-11-23T10:05:19Z" level=error msg="update failed" error="task n6s3jixbxjk4nz8gf4hsumaj4 was already shut down when reached by updater (state: SHUTDOWN)" task.id=j1w3hwkw5idey8xptbf0a9yjv
--- FAIL: TestUpdaterRollback (3.90s)
    --- FAIL: TestUpdaterRollback/continue/spec_version_set (1.64s)
        update_test.go:272: service was updated
        update_test.go:337: 
            	Error Trace:	update_test.go:337
            	            				update_test.go:26
            	Error:      	Not equal: 
            	            	expected: "image2"
            	            	actual  : "image1"
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1 +1 @@
            	            	-image2
            	            	+image1
            	Test:       	TestUpdaterRollback/continue/spec_version_set

@thaJeztah thaJeztah marked this pull request as ready for review November 23, 2022 10:57
@thaJeztah
Copy link
Member Author

Thanks! Bringing this one in; one with the next one 😓 😅

@thaJeztah thaJeztah merged commit 1f21368 into moby:master Nov 23, 2022
@thaJeztah thaJeztah deleted the some_end_to_dependency_hell_step1c branch November 23, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants