ci: use docker github builder to build bin image#51838
Merged
vvoland merged 1 commit intomoby:masterfrom Jan 12, 2026
Merged
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
c015404 to
e709f27
Compare
thaJeztah
reviewed
Jan 12, 2026
| timeout-minutes: 20 # guardrails timeout for the whole job | ||
| if: ${{ always() && !contains(needs.*.result, 'failure') && !contains(needs.*.result, 'cancelled') && (github.event_name != 'pull_request' || !contains(github.event.pull_request.labels.*.name, 'ci/validate-only')) }} | ||
| if: ${{ github.event_name != 'pull_request' || !contains(github.event.pull_request.labels.*.name, 'ci/validate-only') }} | ||
| uses: docker/github-builder-experimental/.github/workflows/bake.yml@7643588149117bf0ca3a906caa3968c70484027a |
Member
There was a problem hiding this comment.
Will there eventually be tags for these?
Member
Author
There was a problem hiding this comment.
Yes definitely when we hit GA, this is tracked in docker/github-builder#74
thaJeztah
approved these changes
Jan 12, 2026
vvoland
reviewed
Jan 12, 2026
| with: | ||
| permissions: | ||
| contents: read # same as global permission | ||
| id-token: write # for signing attestation(s) with GitHub OIDC Token |
Contributor
There was a problem hiding this comment.
Did the signing require some OIDC setup on Docker Inc. side?
Member
Author
There was a problem hiding this comment.
It doesn't, we just use it for signing. In the future we could also use it to login on Docker Hub but it's not GA yet. I started to experiment with it on staging with docker/login-action@master...crazy-max:docker-login-action:dockerhub-oidc and seems to work fine: docker/github-builder#6 (comment)
vvoland
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to docker/github-builder#21
Use the Docker GitHub Builder to build the bin image. It keeps distribution across runners but also generates signed SLSA-compliant provenance attestations.