WIP: pkg/archive: move compression to a separate package

[thaJeztah]

This is really (really!) WIP; something I was considering if this would make sense to do; fun fact; when I started doing this, I noticed that containerd's fork of pkg/archive did exactly the same, so doing this would align our implementation more with containerd's approach; https://github.com/containerd/containerd/tree/v2.0.1/pkg/archive/compression

containerd has some minor differences in the Compression type;

• Compression.Extension() only returns file extension for the compression (e.g. .gzip) instead of also including .tar; https://github.com/containerd/containerd/blob/v2.0.1/pkg/archive/compression/compression.go#L256-L266
• Containerd preserves the compression in the readCloserWrapper, and povides a GetCompression() accessor for this https://github.com/containerd/containerd/blob/v2.0.1/pkg/archive/compression/compression.go#L88-L90
• containerd 2.0 also supports Intel's igzip (in addition to pigz); Use Intel ISA-L's igzip if available containerd/containerd#9200

In reverse, Moby;

• Supports additional compression types (e.g. Xz, Bzip2), which are not supported in containers)
• Has an atomic closed field for readCloserWrapper

  moby/pkg/archive/archive.go

  Lines 221 to 233 in a72026a

  	closed atomic.Bool
  	}
  	func (r *readCloserWrapper) Close() error {
  	if !r.closed.CompareAndSwap(false, true) {
  	log.G(context.TODO()).Error("subsequent attempt to close readCloserWrapper")
  	if log.GetLevel() >= log.DebugLevel {
  	log.G(context.TODO()).Errorf("stack trace: %s", string(debug.Stack()))
  	}
  	return nil
  	}
  	return r.closer()

I'm not sure if we actually need that one though, as it was added to work around an OTEL issue, and not sure if we actually hit that codepath in this code; 585d74b (#46419)

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[dmcgowan]

Supports additional compression types (e.g. Xz, Bzip2), which are not supported in containers)

These can still be supported with containerd, they just need to be registered

[thaJeztah]

Ah, right; yes, I was also looking if we should split out parts to make them more modular "register compression X"

[thaJeztah]

Oh! Right, linter won't be happy yet, because I did not yet update code calling these moved functions;

internal/testutils/archive.go:12:13: SA1019: archive.DecompressStream is deprecated: use [compression.DecompressStream]. (staticcheck)
	rd, err := archive.DecompressStream(compressedTar)
	           ^

[vvoland]

How about compression.None instead of compression.Uncompressed?

Suggested change

	Uncompressed Compression = 0 // Uncompressed represents the uncompressed.
	None Compression = 0 // None represents the uncompressed.

[thaJeztah]

Ah, yes, that works for me; nice and short.

[thaJeztah]

Hmm.. failure could be related; need to check what changed for that test

=== RUN   TestIsArchivePathTar
    archive_test.go:82: Fail to create an archive file for test : tar: Removing leading `/' from member names
        gzip: /tmp/archive: No such file or directory

[thaJeztah]

• Closing in favour of move compression to a separate package go-archive#7