hack/vendor.sh: run "go mod tidy" before vendoring#43212
Merged
thaJeztah merged 1 commit intomoby:masterfrom Feb 5, 2022
Merged
hack/vendor.sh: run "go mod tidy" before vendoring#43212thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
The hack/vendor.sh script is used to (re)vendor dependencies. However, it did not run `go mod tidy` before doing so, wheras the vendor _validation_ script did. This could result in vendor validation failing if go mod tidy resulted in changes (which could be in `vendor.sum`). In "usual" situations, this could be easily done by the user (`go mod tidy` before running `go mod vendor`), but due to our (curent) uses of `vendor.mod`, and having to first set up a (dummy) `go.mod`, this is more complicated. Instead, just make the script do this, so that `hack/vendor.sh` will always produce the expected result. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
Merged
AkihiroSuda
approved these changes
Feb 5, 2022
crazy-max
approved these changes
Feb 5, 2022
Member
Author
|
let's get this one in 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
The hack/vendor.sh script is used to (re)vendor dependencies. However, it did
not run
go mod tidybefore doing so, wheras the vendor validation scriptdid.
This could result in vendor validation failing if go mod tidy resulted in
changes (which could be in
vendor.sum).In "usual" situations, this could be easily done by the user (
go mod tidybefore running
go mod vendor), but due to our (curent) uses ofvendor.mod,and having to first set up a (dummy)
go.mod, this is more complicated.Instead, just make the script do this, so that
hack/vendor.shwill alwaysproduce the expected result.
Signed-off-by: Sebastiaan van Stijn github@gone.nl
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)