Skip to content

Remove use of deprecated client.NewClient()#38604

Merged
yongtang merged 1 commit intomoby:masterfrom
thaJeztah:remove_deprecated_newclient
Jan 28, 2019
Merged

Remove use of deprecated client.NewClient()#38604
yongtang merged 1 commit intomoby:masterfrom
thaJeztah:remove_deprecated_newclient

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jan 21, 2019

Follow-up to #38603

@thaJeztah thaJeztah requested a review from vdemeester January 21, 2019 11:35
@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 21, 2019

@vdemeester @yongtang

vdemeester
vdemeester approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 21, 2019

Whoops;

12:05:03 integration-cli/docker_cli_daemon_test.go:27:2: imported and not used: "github.com/docker/docker/api"
12:05:03 integration-cli/docker_cli_daemon_test.go:29:2: imported and not used: "github.com/docker/docker/client"

Updating

@thaJeztah thaJeztah force-pushed the remove_deprecated_newclient branch from 4e8d987 to fe328f3 Compare January 21, 2019 12:19
@codecov
Copy link

codecov bot commented Jan 21, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@5801c04). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #38604   +/-   ##
=========================================
  Coverage          ?   36.58%           
=========================================
  Files             ?      610           
  Lines             ?    45216           
  Branches          ?        0           
=========================================
  Hits              ?    16542           
  Misses            ?    26393           
  Partials          ?     2281

yongtang
yongtang approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdemeester
Copy link
Member

vdemeester commented Jan 28, 2019

@thaJeztah needs a rebase 🙃 🙏 👼

@thaJeztah
Remove use of deprecated client.NewClient()
3a4bb96 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the remove_deprecated_newclient branch from fe328f3 to 3a4bb96 Compare January 28, 2019 16:09
@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 28, 2019

Rebased 👍

@yongtang yongtang merged commit 0d9dc3f into moby:master Jan 28, 2019
@thaJeztah thaJeztah deleted the remove_deprecated_newclient branch January 28, 2019 21:07
@thaJeztah thaJeztah mentioned this pull request Apr 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@vdemeester vdemeester vdemeester approved these changes

@yongtang yongtang yongtang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/testing status/4-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @vdemeester @yongtang @GordonTheTurtle