Add IMAGE_NAME attribute to journald log events #38032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Kapur <rkapur@flatiron.com>
yongtang
added
status/2-code-review
rebuild/windowsRS1
and removed
status/0-triage
labels
Codecov Report
@@ Coverage Diff @@
## master #38032 +/- ##
=========================================
Coverage ? 36.11%
=========================================
Files ? 610
Lines ? 45187
Branches ? 0
=========================================
Hits ? 16319
Misses ? 26630
Partials ? 2238 |
|
Related documentation PR here |
|
@fntinz @yongtang Do I need to do anything to fix the codecov/patch check? Apologies if this is a stupid question. |
|
@RohitK89 The |
|
Hey folks. Just to confirm, there's nothing else needed from me to move this forward, right? Again, apologies if this is a stupid question. The docs recommend having the documentation change in the same commit, but given that it's a different project, I linked to the relevant PR here. Is that sufficient? |
|
Looks like we have two LGTMs and all tests passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rohit Kapur rkapur@flatiron.com
Closes #21497
- What I did
Adds a new key - IMAGE_NAME - that contains the image:tag value to journald log messages. Note that this makes use of
Info.ImageName()to retrieve the value, which doesn't return the tag if its value islatest.- How I did it
Updated the journald logging driver
- How to verify it
The journald entry returned should have
IMAGE_NAMEas one of the keys- Description for the changelog
Add IMAGE_NAME attribute to journald log event
- A picture of a cute animal (not mandatory but encouraged)
cat