pkg/graphdb build doesn't work on OS X.

[bmatsuo]

This looks like a really cool little package! but the build constraints on the package cause conn_unsupported.go to be used on Darwin.

Does this package actually need build constraints?

[unclejack]

@bmatsuo That package doesn't support OS X because it's not supported. Docker doesn't have any execdriver to allow it to run on OS X. It doesn't make sense to support OS X in graphdb because we're only building Docker clients for OS X.

[bmatsuo]

I'm not trying to build Docker on OS X.

The pkg directory was recently advertised in @crosbymichael's blog and at GopherCon as being a set of general purpose packages. IMO general purpose packages shouldn't have unnecessary build constraints.

[tianon]

These packages also have to cross compile correctly, which is a major
reason they may have overzealous build flags. You can test the cross
compilation from in the docker repo with "make cross".

[crosbymichael]

@tianon they are talking about using the graphdb package in their own project on osx.
I think we can change this and add a sqlite or something built tag for a make cross stuff

[tianon]

I've seen us use the "cgo" build flag for this previously; maybe that would work?

[crosbymichael]

Yes, i think the cgo flag should work

[bmatsuo]

they are talking about using the graphdb package in their own project on osx

That's right. Thanks for clarifying that @crosbymichael.

So the desired changes would be an additional darwin,cgo build tag on conn_sqlite3.go and corresponding changes for conn_unsupported.go?

[tianon]

Yes, that sounds like it'd work well.