Add RWMutexMap for read-write locks #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cory Snider <csnider@mirantis.com>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new RWMutexMap type that provides a convenient way to access per-key read–write locks and includes extensive tests and benchmarks to ensure proper behavior under concurrency.
- Implements RWMutexMap for dynamic per-key locking.
- Provides unit tests covering lock, unlock, read lock, and concurrent scenarios.
- Adds benchmark tests for performance evaluation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rwmutexmap_test.go | Adds tests and benchmark cases for the new RWMutexMap functionality. |
| rwmutexmap.go | Implements the RWMutexMap and its associated locking methods. |
vvoland
approved these changes
May 23, 2025
cpuguy83
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.