Explicitly disable VMCS shadowing

[agustingianni]

On macOS Catalina VM creation fails with:

vmx_set_ctlreg: cap_field: 2 bit: 14 unspecified don't care
vmx_init: processor does not support desired secondary processor-based controls
Unable to create VM (22)

Add the VMCS shadow control bit to the list of disabled controls.

Original patch by John Coyle machyve/xhyve@0c3c50a

[GordonTheTurtle]

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "master" git@github.com:agustingianni/hyperkit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

[justincormack]

Thanks. Curious about your setup as we haven't had any reports of failures with Catalina, and we have tests running for it, so your environment must differ in some way (different hardware?).

[agustingianni]

Hello @justincormack my setup is:

MacBook Pro (Retina, 15-inch, Mid 2015)
2,5 GHz Quad-Core Intel Core i7

I figured it was Catalina because the last time I've used hyperkit on the previous macOS version I did not have this issue.

There is at least another person having the same issue here kubernetes/minikube#5610

Let me know if you need anything!

[justincormack]

Ah, my machine of that date suffered from the exploding battery issue and its still with Apple, but from the other thread looks like there is a feature missing in some older CPUs.

We are taking a look at the build errors which are unrelated.

[agustingianni]

Let me know if you need me to run some tests. Cheers.

[justincormack]

Can you rebase, we fixed the CI issue.

[agustingianni]

I just rebased with upstream. Hope I did not mess it up. Thanks!

[justincormack]

Thanks!