dockerfile: fix building dfextall#659
Merged
AkihiroSuda merged 1 commit intomoby:masterfrom Oct 3, 2018
Merged
Conversation
Member
Author
Actually, all the release tags should be defined like this. Eg: secrets is a list of |
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
fix-dfextall
branch
from
11e0407 to
d40d557
Compare
AkihiroSuda
approved these changes
Oct 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #657
This is a temp fix. I'll do something better soon that also tests all variants.
I'm also ok with just removing
dfextall, replacing it with a list of tags that we count as experimental and building with-tags $(cat ./extalltags)@AkihiroSuda
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com