Fix markdown/links for AWS auth #6379
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SDK link didn't end in a parenthesis, resulting in the markdown not getting rendered as intended. The resulting 'bare' go.dev link looked out of place, so moved it to a more natural location. Lastly, SDK link was for v1 docs, though the code actually uses v2; it has been replaced with the v2 equivalent. Signed-off-by: Roberto Villarreal <rrjjvv@yahoo.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK link didn't end in a parenthesis, resulting in the markdown not getting rendered as intended.
The resulting 'bare' go.dev link looked out of place, so moved it to a more natural location.
Lastly, the SDK link was for v1 docs, though the code actually uses v2; it has been replaced with the v2 equivalent.
@bpaquet I couldn't tell if your intent was possibly to to replace the AWS link with the go.dev link, but based on the context of #5926 I'm sure the presence of the go.dev link was intentional. If your intent was to have the go.dev link as-is, adjacent to the AWS link, I'll change it back. My main goal was simply fixing the markdown.