client: enable git signature checks via policy #6344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
commented
Nov 7, 2025
| if id.VerifySignature == nil { | ||
| id.VerifySignature = &GitSignatureVerifyOptions{} | ||
| } | ||
| id.VerifySignature.PubKey = []byte(v) |
Member
Author
There was a problem hiding this comment.
I think in the future we probably would also want pubkey via URL, that is then internally loaded in via llb.HTTP but I think we can leave that to future iteration.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
git-policy-signatures
branch
from
5cffa8a to
a372e4e
Compare
cpuguy83
approved these changes
Nov 8, 2025
jsternberg
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect Git signature verification to LLB attributes and add tests.