Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/system: deprecate Atime implementation for containerd/continuity/fs #5465

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

util/system: deprecate Atime implementation for containerd/continuity/fs #5465

wants to merge 2 commits into from
+70 −70

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Oct 29, 2024 •
edited
Loading

vendor: github.com/containerd/continuity v0.4.5

full diff: containerd/continuity@v0.4.4...v0.4.5

util/system: deprecate Atime implementation for containerd/continuity/fs

These were added in 0b5a315, because the continuity/fs package did not provide a Windows implementation. They were upstreamed in continuity@3cbda8c, which is part of continuity v0.4.4, so we can deprecate the implementation here.

@thaJeztah
Copy link
Member Author

Ah, dang; probably continuity uses _linux.go instead of _unix.go ?

27.21 # github.com/moby/buildkit/util/system
27.21 util/system/atime_deprecated.go:12:12: undefined: fs.Atime
35.19 # github.com/moby/buildkit/executor
35.19 executor/stubs.go:89:21: undefined: fs.Atime

@thaJeztah
Copy link
Member Author

Ah, it uses specific build-tags, has openbsd but not freebsd

buildkit/vendor/github.com/containerd/continuity/fs/stat_unix.go

Line 1 in fd61877

//go:build linux || openbsd || dragonfly || solaris

@thaJeztah thaJeztah mentioned this pull request Oct 30, 2024
Merged
@thaJeztah thaJeztah self-assigned this Oct 30, 2024
@thaJeztah thaJeztah marked this pull request as draft October 31, 2024 13:21
@github-actions github-actions bot added the area/dependencies Pull requests that update a dependency file label Oct 31, 2024
@thompson-shaun thompson-shaun added this to the v0.18.0 milestone Oct 31, 2024
@thaJeztah
vendor: github.com/containerd/continuity v0.4.5
8530ae8 
full diff: containerd/continuity@v0.4.4...v0.4.5

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
util/system: deprecate Atime implementation for containerd/continuity/fs
195cef1 
These were added in 0b5a315, because the
continuity/fs package did not provide a Windows implementation. They
were upstreamed in [continuity@3cbda8c], which is part of continuity v0.4.4,
so we can deprecate the implementation here.

[continuity@3cbda8c]: https://github.com/containerd/continuity//commit/3cbda8c24bde1ce635ff5dc3417a481a3b6b6e07

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah marked this pull request as ready for review November 14, 2024 21:34
@thaJeztah
Copy link
Member Author

continuity v0.4.5 was tagged which now has all the changed needed; @AkihiroSuda @tonistiigi PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda Awaiting requested review from AkihiroSuda

At least 1 approving review is required to merge this pull request.

Assignees

@thaJeztah thaJeztah

Labels
area/dependencies Pull requests that update a dependency file area/executor area/util area/windows
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thaJeztah @thompson-shaun