tests: frontend/dockerfile: update integration tests for windows/wcow #5382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profnandaa
reviewed
Oct 3, 2024
danielGithinji
force-pushed
the
integration-tests
branch
from
d8a972d
to
4c751c4
Compare
danielGithinji
force-pushed
the
integration-tests
branch
5 times, most recently
from
47e451c
to
7a25fb0
Compare
- [x] `testCopyThroughSymlinkContext` - [x] `testIgnoreEntrypoint` - [x] `testQuotedMetaArgs` - [x] `testDockerfileCheckHostname` - [x] `testEmptyStages` - [x] `testNamedImageContextScratch` - [x] `testNamedImageContextPlatform` Signed-off-by: Daniel Githinji <danskigee@gmail.com>
danielGithinji
force-pushed
the
integration-tests
branch
from
7a25fb0
to
ccdd43b
Compare
profnandaa
reviewed
Nov 13, 2024
| `, | ||
| ` | ||
| FROM nanoserver | ||
| RUN reg query "HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\Tcpip\Parameters" /v Hostname| findstr "foo" |
There was a problem hiding this comment.
nit: we will need to check if this command actually returned something or failed and exit appropriately,
billywr
reviewed
Nov 13, 2024
| f := getFrontend(t, sb) | ||
| dockerfile := []byte(` | ||
| dockerfile := []byte(integration.UnixOrWindows( | ||
| ` | ||
| ARG foo=bar |
There was a problem hiding this comment.
ARG foo=bar is same for both linux and windows no need to use .UnixOrWindows
billywr
reviewed
Nov 13, 2024
| @@ -6708,7 +6743,14 @@ func testNamedImageContextPlatform(t *testing.T, sb integration.Sandbox) { | |||
| require.NoError(t, err) | |||
|
|
|||
| // Build a base image and force buildkit to generate a manifest list. | |||
| dockerfile := []byte(`FROM --platform=$BUILDPLATFORM alpine:latest`) | |||
| dockerfile := []byte(integration.UnixOrWindows( | |||
There was a problem hiding this comment.
Lin 6746 to 6753 can be collapsed to
baseImage := integration.UnixOrWindows(
"alpine",
"nanoserver",
)
dockerfile := []byte(fmt.Sprintf(`FROM --platform=$BUILDPLATFORM %s:latest`, baseImage))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Windows.
Partially addressing #4485
testCopyThroughSymlinkContexttestIgnoreEntrypointtestQuotedMetaArgstestDockerfileCheckHostnametestEmptyStagestestNamedImageContextScratchtestNamedImageContextPlatform