history: remove records without attached blobs at startup #5378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
history-prune-orphans
branch
from
e3f368c
to
882208d
Compare
tonistiigi
reviewed
Oct 1, 2024
solver/llbsolver/history.go
Outdated
| @@ -298,13 +300,28 @@ func (h *HistoryQueue) gc() error { | |||
| if br.Pinned { | |||
| return nil | |||
| } | |||
| records = append(records, &br) | |||
| recs, err := h.hLeaseManager.ListResources(ctx, leases.Lease{ID: h.leaseID(string(key))}) | |||
There was a problem hiding this comment.
Can we do this only for the first time, to validate if something went wrong in between restarts.
We should also print a warning to daemon logs if we find such a case.
crazy-max
force-pushed
the
history-prune-orphans
branch
from
882208d
to
0c37d9d
Compare
crazy-max
changed the title
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
history-prune-orphans
branch
from
0c37d9d
to
2c10f56
Compare
tonistiigi
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up moby/moby#48565 (comment)