exec: allow specifying non-zero exit codes for execs #5339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/llb
area/testing
area/client
area/executor
area/solver
labels
jedevc
force-pushed
the
exec-exit-codes
branch
from
39349a4
to
dd57a38
Compare
jedevc
force-pushed
the
exec-exit-codes
branch
from
dd57a38
to
60e2295
Compare
tonistiigi
reviewed
Sep 16, 2024
jedevc
force-pushed
the
exec-exit-codes
branch
from
60e2295
to
7e6c20a
Compare
Signed-off-by: Justin Chadwell <me@jedevc.com>
tonistiigi
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed originally in slack: https://dockercommunity.slack.com/archives/C7S7A40MP/p1724155627856519
Turns out to be fairly trivial to plumb through, don't think there should be anything too controversial here.
I'll leave it to docker folks though to determine if this should be exposed in the dockerfile syntax in the future, I could imagine a
--exitflag forRUNwhich would be nice. Though I think probably out-of-scope for this initial PR.