frontend/dockerfile/docs: add $ in mount env example #5333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ryio1010 <info@ryio1010.com>
crazy-max
reviewed
Sep 13, 2024
| @@ -842,7 +842,7 @@ environment variable with the same name. | |||
| # syntax=docker/dockerfile:1 | |||
| FROM alpine | |||
| RUN --mount=type=secret,id=API_KEY,env=API_KEY \ | |||
| some-command --token-from-env API_KEY | |||
| some-command --token-from-env $API_KEY | |||
There was a problem hiding this comment.
iiuc current is the name of the var that would then be solved within some-command logic. cc @dvdksn
There was a problem hiding this comment.
yeah, that was the idea, but I admit that it isn't really a great example. Any better suggestions are welcome
There was a problem hiding this comment.
thanks for reviewing, and I see.
I have no idea with alternative great example for now🙏
tonistiigi
approved these changes
Sep 17, 2024
billywr
pushed a commit
to billywr/buildkit
that referenced
this pull request
Sep 23, 2024
frontend/dockerfile/docs: add $ in mount env example Signed-off-by: Billy Owire <billyowire95@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added $ in 'Example: Mount as environment variable' sample command because it is needed to refer to env.