Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v0.16] cherry-picks for v0.16.0 #5320

Merged
merged 2 commits into from
Sep 10, 2024
Merged

[v0.16] cherry-picks for v0.16.0 #5320

merged 2 commits into from
Sep 10, 2024

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Sep 10, 2024 •
edited
Loading

@crazy-max
vendor: github.com/docker/docker v27.2.1
5c5dc59 
full diff:
- docker/cli@v27.2.0...v27.2.1
- docker/cli@v27.2.0...v27.2.1

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
(cherry picked from commit a31bae9)
@github-actions github-actions bot added area/windows area/dependencies Pull requests that update a dependency file labels Sep 10, 2024
@thompson-shaun @crazy-max
fix windows area label when modifications are under the vendor folder
74116a2 
Signed-off-by: Shaun Thompson <shaun.thompson@docker.com>
(cherry picked from commit 3b3eaca)
thaJeztah
thaJeztah approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonistiigi
Copy link
Member

@crazy-max Looks like the labeler update did not work?

@crazy-max
Copy link
Member Author

Yes that's because target branch v0.16 does not have the fix I cherry picked.

When using pull_request_target it runs from base branch only: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request_target

This event runs in the context of the base of the pull request, rather than in the context of the merge commit, as the pull_request event does.

@crazy-max crazy-max mentioned this pull request Sep 10, 2024
Merged
@crazy-max crazy-max merged commit 0865fcc into moby:v0.16 Sep 10, 2024
91 checks passed
@crazy-max crazy-max deleted the v0.16.0-picks2 branch September 10, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@tonistiigi tonistiigi tonistiigi approved these changes

@daghack daghack Awaiting requested review from daghack

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crazy-max @tonistiigi @thaJeztah @thompson-shaun