fix: 20 sec timeout for write to disc too short #4944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 sec stall on an platter old hdd is not unexpected. Nor is 20s write on a low-tier cloud environment drive unexpected. 300s should however be enough to tell the difference between crappy hardware and actual failure. fixes moby#4327 Signed-off-by: Dennis Haney <davh@davh.dk>
tonistiigi
approved these changes
May 22, 2024
|
#4947 could be one of the reasons you reached the timeout before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
20 sec stall on an platter old hdd is not unexpected. Nor is 20s write on a low-tier cloud environment drive unexpected.
300s should however be enough to tell the difference between crappy hardware/environment and actual failure.
fixes #4327