Add MediaType in index.json when --out type=oci
#4727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Talon Bowler <talon.bowler@docker.com>
tonistiigi
reviewed
Mar 3, 2024
client/client_test.go
Outdated
| }, nil) | ||
| require.NoError(t, err) | ||
|
|
||
| _, err = os.Stat(filepath.Join(outDir, "index.json")) |
There was a problem hiding this comment.
nit: Stat here does not seem to be needed. ReadFile would fail with same error if file does not exist.
Signed-off-by: Talon Bowler <talon.bowler@docker.com>
tonistiigi
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #4595 and adds appropriate test. Specifically, this catches the case where
tar=false, which is not covered by the incoming containerd fix. ( It should also happen fix the issue more generally, but getting the containerd was the correct fix in the general case. 😄 )