Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scaffolding on npm install #265

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Conversation

jvcmanke
Copy link

Fixes #208

When installed with npm the node_modules folder has a different structure, therefore we should use the one that is common between npm and yarn.

@special-character
Copy link
Contributor

@jvcmanke Thanks for the PR, I tested it out with both yarn and npm. Looks good 👍

@special-character special-character self-requested a review August 12, 2020 17:18
Copy link
Contributor

@special-character special-character left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with both npm and yarn.

@special-character special-character merged commit 3a45c69 into mobxjs:main Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation using NPM fails
3 participants