Fix issue with wrong inferred type of observable.map in TS 5.9+#4578
Merged
mweststrate merged 2 commits intomobxjs:mainfrom Sep 26, 2025
Merged
Fix issue with wrong inferred type of observable.map in TS 5.9+#4578mweststrate merged 2 commits intomobxjs:mainfrom
mweststrate merged 2 commits intomobxjs:mainfrom
Conversation
|
Member
|
Thanks for putting this PR and others up! I'll try to review later this or next week, as I've been out of the loop for a bit, I'll need some time to catch up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #4573
The issue is that since TypeScript 5.9, a particular pattern for calling
observable.mapcaused a compiler error. Comparing with the definition ofnew Map, I saw that we could fix this by using function overloads instead of the union type.Before

After
