Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for #3853 #3898

Merged
merged 29 commits into from
Jul 2, 2024
Merged

Fixes for #3853 #3898

merged 29 commits into from
Jul 2, 2024

Conversation

inoyakaigor
Copy link
Contributor

Code change checklist

  • Added/updated unit tests
  • Updated /docs. For new functionality, at least API.md should be updated
  • Verified that there is no significant performance drop (yarn mobx test:performance)

inoyakaigor and others added 29 commits April 2, 2024 14:15
…ange strict inequality operator to strict equality
…ich gives different results depends on place of operands:

SET1 AGAINST SET2
  intersection         Set(2) { 1, 2 }
  union                Set(6) { 1, 2, 3, 4, 5, 6 }
  difference           Set(2) { 4, 5 }
  symmetricDifference  Set(3) { 1, 2, 5 }
  isSubsetOf           false
  isSupersetOf         false
  isDisjointFrom       true

SET2 AGAINST SET1
  intersection         Set(2) { 1, 2 }
  union                Set(6) { 1, 2, 6, 3, 4, 5 }
  difference           Set(0) {}
  symmetricDifference  Set(3) { 1, 2, 5 }
  isSubsetOf           true
  isSupersetOf         true
  isDisjointFrom       true
# Conflicts:
#	.github/workflows/coveralls.yml
Copy link

changeset-bot bot commented Jul 2, 2024

🦋 Changeset detected

Latest commit: 5db8f2f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mobx Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@inoyakaigor inoyakaigor mentioned this pull request Jul 2, 2024
3 tasks
@urugator urugator merged commit 16f070e into mobxjs:main Jul 2, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
@urugator
Copy link
Collaborator

urugator commented Jul 2, 2024

@inoyakaigor
Copy link
Contributor Author

@urugator should be fixd in PR #3900

@urugator
Copy link
Collaborator

urugator commented Jul 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants