-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Local fork] TC 39 decorators #3790
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rick Pastoor <rickpastoor@gmail.com>
…tchlighter-decorators2022-2
🦋 Changeset detectedLatest commit: ca9e18a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@render preview |
5 tasks
urugator
reviewed
Nov 10, 2023
Merged
This triggers a compilation error.
|
Yes please upgrade TS. TS doesn't support semantic versioning so we don't
account for that in our releases.
…On Wed, 20 Mar 2024, 12:11 William Desportes, ***@***.***> wrote:
This triggers a compilation error.
6.10.x are the last working versions for me.
Should TypeScript 5.x be required ? I am using TS 4.
Error: node_modules/mobx/dist/api/annotation.d.ts:11:42 - error TS2304: Cannot find name 'DecoratorContext'.
11 decorate_20223_(value: any, context: DecoratorContext): any;
~~~~~~~~~~~~~~~~
Error: node_modules/mobx/dist/api/decorators.d.ts:19:68 - error TS2304: Cannot find name 'DecoratorContext'.
19 export declare function is20223Decorator(context: any): context is DecoratorContext;
~~~~~~~~~~~~~~~~
Error: node_modules/mobx/dist/api/decorators.d.ts:20:59 - error TS2304: Cannot find name 'DecoratorContext'.
20 export declare function assert20223DecoratorType(context: DecoratorContext, types: DecoratorContext["kind"][]): void;
~~~~~~~~~~~~~~~~
Error: node_modules/mobx/dist/api/decorators.d.ts:20:84 - error TS2304: Cannot find name 'DecoratorContext'.
** Angular Live Development Server is listening on 0.0.0.0:4200, open your browser on http://localhost:4200/ **
20 export declare function assert20223DecoratorType(context: DecoratorContext, types: DecoratorContext["kind"][]): void;
~~~~~~~~~~~~~~~~
Error: node_modules/mobx/dist/types/decorator_fills.d.ts:1:71 - error TS2552: Cannot find name 'ClassAccessorDecoratorTarget'. Did you mean 'ClassAccessorDecorator'?
1 export type ClassAccessorDecorator<This = any, Value = any> = (value: ClassAccessorDecoratorTarget<This, Value>, context: ClassAccessorDecoratorContext) => ClassAccessorDecoratorResult<This, Value> | void;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error: node_modules/mobx/dist/types/decorator_fills.d.ts:1:123 - error TS2552: Cannot find name 'ClassAccessorDecoratorContext'. Did you mean 'ClassAccessorDecorator'?
1 export type ClassAccessorDecorator<This = any, Value = any> = (value: ClassAccessorDecoratorTarget<This, Value>, context: ClassAccessorDecoratorContext) => ClassAccessorDecoratorResult<This, Value> | void;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error: node_modules/mobx/dist/types/decorator_fills.d.ts:1:157 - error TS2552: Cannot find name 'ClassAccessorDecoratorResult'. Did you mean 'ClassAccessorDecorator'?
1 export type ClassAccessorDecorator<This = any, Value = any> = (value: ClassAccessorDecoratorTarget<This, Value>, context: ClassAccessorDecoratorContext) => ClassAccessorDecoratorResult<This, Value> | void;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
✖ Failed to compile.
Error: node_modules/mobx/dist/types/decorator_fills.d.ts:2:101 - error TS2552: Cannot find name 'ClassGetterDecoratorContext'. Did you mean 'ClassGetterDecorator'?
2 export type ClassGetterDecorator<This = any, Value = any> = (value: (this: This) => Value, context: ClassGetterDecoratorContext) => ((this: This) => Value) | void;
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error: node_modules/mobx/dist/types/decorator_fills.d.ts:3:114 - error TS2552: Cannot find name 'ClassSetterDecoratorContext'. Did you mean 'ClassSetterDecorator'?
3 export type ClassSetterDecorator<This = any, Value = any> = (value: (this: This, value: Value) => void, context: ClassSetterDecoratorContext) => ((this: This, value: Value) => void) | void;
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error: node_modules/mobx/dist/types/decorator_fills.d.ts:4:114 - error TS2552: Cannot find name 'ClassMethodDecoratorContext'. Did you mean 'ClassMethodDecorator'?
4 export type ClassMethodDecorator<This = any, Value extends (...p: any[]) => any = any> = (value: Value, context: ClassMethodDecoratorContext<This, Value>) => Value | void;
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error: node_modules/mobx/dist/types/decorator_fills.d.ts:5:113 - error TS2552: Cannot find name 'ClassFieldDecoratorContext'. Did you mean 'ClassFieldDecorator'?
5 export type ClassFieldDecorator<This = any, Value extends (...p: any[]) => any = any> = (value: Value, context: ClassFieldDecoratorContext<This, Value>) => Value | void;
~~~~~~~~~~~~~~~~~~~~~~~~~~
—
Reply to this email directly, view it on GitHub
<#3790 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN4NBC6S6KZQ2R2LOYVHKDYZFVFLAVCNFSM6AAAAAA6Z4F5ZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBZGMZDEMBWG4>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local fork with additional updates to @Matchlighter 's awesome work.
Follow progress in #3638