Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Prevent calling set on the return value of 'computed()' #3783

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nokel81
Copy link
Contributor

@Nokel81 Nokel81 commented Oct 26, 2023

BREAKING CHANGE: 'set()' method now only exists if a 'set()' is provided

Code change checklist

  • Added/updated unit tests
  • Updated /docs. For new functionality, at least API.md should be updated
  • Verified that there is no significant performance drop (yarn mobx test:performance)

resolves #3767

BREAKING CHANGE: 'set()' method now only exists if a 'set()' is provided

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2023

🦋 Changeset detected

Latest commit: b2d9f64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
mobx Major
mobx-react-lite Major
mobx-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The value returned from computed(() => ...) shouldn't have a set(...) method
1 participant