Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: makeObservable gets added to the type import #2429

Merged
merged 1 commit into from
Aug 17, 2020
Merged

fix: makeObservable gets added to the type import #2429

merged 1 commit into from
Aug 17, 2020

Conversation

MoonBall
Copy link
Contributor

@MoonBall MoonBall commented Aug 12, 2020 •
edited by gitpod-io bot
Loading

fix #2415.

Code change checklist

  • Added/updated unit tests
  • Updated changelog
  • Updated /docs. For new functionality, at least API.md should be updated
  • Verified that there is no significant performance drop (npm run perf)

@gitpod-io
Copy link

gitpod-io bot commented Aug 12, 2020

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.516% when pulling 9be3a0c on add-makeObservable-to-the-non-type-import into f6b65b0 on mobx6.

@mweststrate
Copy link
Member

Great stuff, thanks for fixing this one and adding tests @MoonBall!

@mweststrate mweststrate merged commit a0627f8 into mobx6 Aug 17, 2020
@danielkcz danielkcz deleted the add-makeObservable-to-the-non-type-import branch August 17, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mobx-undecorate adds import incorrectly when importing mobx types
3 participants
@MoonBall @coveralls @mweststrate