This repository has been archived by the owner on Dec 31, 2020. It is now read-only.
Replace Rollup build with TSDX #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #168
I've decided to give this a green light because of amount of Rollup deps that are upgraded often is breathtaking.
I chose TSDX over microbundle because it does provide better output, eg. minified prod bundle, unminified dev one.
There is still a soft breaking change that
index.jsis no longer UMD compatible, but if someone is using the lib as UMD, they can simply lookup new url by going to https://unpkg.com/mobx-react-lite (after this is published).Merging right away since nobody expressed an opinion on the linked issue before.