Skip to content

Commit

Permalink
revert commit node modules
Browse files Browse the repository at this point in the history
  • Loading branch information
callms committed Mar 12, 2024
1 parent 552cfe5 commit 7db67b0
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/actions/pullRequest.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ exports.validatePR = async function validatePR({ pullRequest, issue }) {

if (!isBranchNameValid(headRef)) {
throw new Error(
`This pull request is based on a branch with in invalid name: “${headRef}”. See https://www.notion.so/mobsuccess/Git-Guidelines-41996ef576cb4f29b7737772b74289c5#f9cadc10d949498dbe38c0eed08fd4f8`
`This pull request is based on a branch with in invalid name: “${headRef}”. See https://github.com/mobsuccess-devops/rfc/blob/master/docs/decisions/0009-convention-nommage-branch-pr.md and https://www.notion.so/mobsuccess/Git-Guidelines-41996ef576cb4f29b7737772b74289c5#f9cadc10d949498dbe38c0eed08fd4f8`
);
}

Expand Down
8 changes: 8 additions & 0 deletions lib/branch.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
function isBranchNameValid(branchName) {
return (
// The following are the older branch prefixes, that are still valid, with
// discussions pending on the ADR #9 with a PR #35 still active at the time
// of writing, to maybe deprecate them. In the meantime we still have to
// allow branches using these prefixes, as no active ADR disallows their
// use.
!!branchName.match(
/^(core|feature|fix|hotfix|asset|rework|documentation)\/([a-z][a-z0-9._-]*)$/
) ||
!!branchName.match(
/^(feat|fix|chore|docs|refactor|test|revert|ci|perf|style|build|change|remove|poc|mobsuccessbot|dependabot)\/([a-z][a-z0-9._-]*)$/
) ||
Expand Down

0 comments on commit 7db67b0

Please sign in to comment.