Skip to content

Conversation

@MaciejCiemiega
Copy link
Member

Update of Bitcoin Checker API to support futures prices on DataModule level + update of DataModuleTester app to support it.

The remaining part is to also add this support to Bitcoin Checker client. I've already updated the Checker edit screen but I have few questions for you what is the best way to display such Checker on Main screen, notifications or on widget. This solution is more flexible than "a workaround" solution from here: #174 so we have more freedom how to present this data in app.

@joseccnet @btcdrak
Please share your thoughts about the price presentation in app.

screenshot_20151017-102635

screenshot_20151017-102609

@btcdrak
Copy link

btcdrak commented Oct 17, 2015

What does the notification area look like for OKCoin futures?

@btcdrak
Copy link

btcdrak commented Oct 17, 2015

I like it, this means we can support thing Huobi's BitVC as well for example.

@MaciejCiemiega
Copy link
Member Author

Because things like "1W", "2W" etc are separated from the base currency field it behaves and look like normal Checker. Currently the only difference is that there is one additional field in Checker edit screen.

@btcdrak
Copy link

btcdrak commented Oct 17, 2015

@MaciejCiemiega yes, I'm quite happy with this too. Would just like to see how it looks in the notification area. Conceptual ACK from me. Good work!

@MaciejCiemiega
Copy link
Member Author

Notification:
screenshot_20151017-104546

Main screen:
screenshot_20151017-104649

So the same as standard Checker. But I think we should indicate somewhere the contract type - that will also give a hint that it's from Futures.

@btcdrak
Copy link

btcdrak commented Oct 17, 2015

Right, it's simple, simply append the contract type to the base, so BTC1W, LTC3M etc. This is how we did it in the other PR.

@btcdrak
Copy link

btcdrak commented Oct 17, 2015

For the screenshot of "Main Screen", you could put the contract type in the currency pair, so BTC1W/USD. Everyone who trades futures understands the abbreviations and on TradingView (the no.1 charting platform) they also use similar notation.

@MaciejCiemiega
Copy link
Member Author

I know how it looked like in other PR, but since we have more freedom here (we are not restricted with hardcoded "BTC1W" currency names) we can do it in any way. Although if "BTC1W" is the preferred presentation I will just to that.
I have a plan to work on it probably later today. I don't know when exactly it will be ready but it may be a good idea to release a private alpha to you guys so you will have access to this update before it will be available to the rest of users on Google Play Store. What do you think?

@btcdrak
Copy link

btcdrak commented Oct 17, 2015

@MaciejCiemiega I'd be happy to test an .apk if you email it.

@btcdrak
Copy link

btcdrak commented Oct 17, 2015

I think in absence of other suggestions, let's go with BTC1W, we can always improve on it later if someone comes up with a better display.

@MaciejCiemiega
Copy link
Member Author

@btcdrak I was thinking about alpha on Google Play store so you will be able to just update it as a normal update. It will be more convenient for both sides I think:)

@btcdrak
Copy link

btcdrak commented Oct 17, 2015

@MaciejCiemiega I donjt use Google Play, I use a mod ROM and download APKs manually.

@MaciejCiemiega
Copy link
Member Author

This is how it looks now.

Main screen:
screenshot_20151017-141509

Notification:
screenshot_20151017-141444

Widget:
screenshot_20151017-141438

I've also changed it in notifications for alarm and compact widget items.

What is your opinion about adding contract type also to TTS announcements? Is this necessary? On one hand it could be helpful, but on the other voice announcements should be as short as possible IMO.

@btcdrak
Copy link

btcdrak commented Oct 17, 2015

I think it's good as it is. Too much information in the notification makes it noisy IMO. You could add something to the extended notification (when you expand them) if f you like, but as per your screenshot is perfect.

@btcdrak
Copy link

btcdrak commented Oct 19, 2015

PR needs rebase

MaciejCiemiega added a commit that referenced this pull request Nov 1, 2015
Support for futures and OKCoin Futures
@MaciejCiemiega MaciejCiemiega merged commit 67d80dc into master Nov 1, 2015
@MaciejCiemiega
Copy link
Member Author

This will be included in update 1.6 which I will try to release today.
Cheers!

@btcdrak
Copy link

btcdrak commented Nov 1, 2015

Thanks! Great work!

@MaciejCiemiega MaciejCiemiega deleted the futures branch December 12, 2016 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants