-
Notifications
You must be signed in to change notification settings - Fork 207
Support for futures and OKCoin Futures #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What does the notification area look like for OKCoin futures? |
|
I like it, this means we can support thing Huobi's BitVC as well for example. |
|
Because things like "1W", "2W" etc are separated from the base currency field it behaves and look like normal Checker. Currently the only difference is that there is one additional field in Checker edit screen. |
|
@MaciejCiemiega yes, I'm quite happy with this too. Would just like to see how it looks in the notification area. Conceptual ACK from me. Good work! |
|
Right, it's simple, simply append the contract type to the base, so BTC1W, LTC3M etc. This is how we did it in the other PR. |
|
For the screenshot of "Main Screen", you could put the contract type in the currency pair, so BTC1W/USD. Everyone who trades futures understands the abbreviations and on TradingView (the no.1 charting platform) they also use similar notation. |
|
I know how it looked like in other PR, but since we have more freedom here (we are not restricted with hardcoded "BTC1W" currency names) we can do it in any way. Although if "BTC1W" is the preferred presentation I will just to that. |
|
@MaciejCiemiega I'd be happy to test an .apk if you email it. |
|
I think in absence of other suggestions, let's go with BTC1W, we can always improve on it later if someone comes up with a better display. |
|
@btcdrak I was thinking about alpha on Google Play store so you will be able to just update it as a normal update. It will be more convenient for both sides I think:) |
|
@MaciejCiemiega I donjt use Google Play, I use a mod ROM and download APKs manually. |
|
This is how it looks now. I've also changed it in notifications for alarm and compact widget items. What is your opinion about adding contract type also to TTS announcements? Is this necessary? On one hand it could be helpful, but on the other voice announcements should be as short as possible IMO. |
|
I think it's good as it is. Too much information in the notification makes it noisy IMO. You could add something to the extended notification (when you expand them) if f you like, but as per your screenshot is perfect. |
|
PR needs rebase |
futures /MarketsConfig.java Conflicts: DataModule/src/com/mobnetic/coinguardian/config/MarketsConfig.java
Support for futures and OKCoin Futures
|
This will be included in update 1.6 which I will try to release today. |
|
Thanks! Great work! |





Update of Bitcoin Checker API to support futures prices on DataModule level + update of DataModuleTester app to support it.
The remaining part is to also add this support to Bitcoin Checker client. I've already updated the Checker edit screen but I have few questions for you what is the best way to display such Checker on Main screen, notifications or on widget. This solution is more flexible than "a workaround" solution from here: #174 so we have more freedom how to present this data in app.
@joseccnet @btcdrak
Please share your thoughts about the price presentation in app.