-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DataTransfer data types #537
fix: DataTransfer data types #537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, could you also add an entry in the ChangeLog.md?
My read on the spec for this is different. The Field Type for This is a pretty confusing part of the spec, though, I could certainly be wrong. It looks like it has a mistake in it as well, because the capitalization isn't consistent between the Field Types |
@malsyned Good catch! You're right. I think we should revert this change. |
…ta typehint. The typehint should be a str type, rather than Any.
Interesting, I read "Text, data" to mean "Text OR data" - agreed it's not clear though I think @OrangeTux will ask the OCA for a clarification |
In 2.0.1 both DataTransferRequest and DataTransferResponse have a field called
data
which is defined asAnyType
so I believe these should both by of typeAny
here