Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes with 'v2x' are serialized as 'V2x', but should be serialized as 'V2X' #522

Conversation

Jared-Newell-Mobility
Copy link
Contributor

No description provided.

Copy link
Collaborator

@OrangeTux OrangeTux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an example of string that's mutated incorrectly?

@Jared-Newell-Mobility
Copy link
Contributor Author

This is the example you gave in #431

@OrangeTux
Copy link
Collaborator

Can you add a test to cover the change?

@OrangeTux
Copy link
Collaborator

This is the example you gave in #431

Lol, I must have forgotten this.

Copy link
Contributor

@tmh-grunwald-markus tmh-grunwald-markus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The handling of V2X is ok, but to avoid confusion I would handle SoC at the start of a word in the same way (which is not the point of THIS PR).

Copy link
Collaborator

@OrangeTux OrangeTux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OrangeTux OrangeTux merged commit 71fee9c into master Jan 9, 2024
5 checks passed
@OrangeTux OrangeTux deleted the Attributes-with-'v2x'-are-serialized-as-'V2x',-but-should-be-serialized-as-'V2X' branch January 9, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants