Skip to content

Error when the private recipe repo url is a ssh git url #13

Closed
@lainosantos

Description

@lainosantos

Hello :D

The version 1.0.0 has a bug when the private recipe repo url is a ssh git url. Per exemple, i'm using a private gitlab instance and the private repo url is git@gitlab:symfony/recipes.git.

It's beacause the https://github.com/moay/symfony-flex-server/blob/d07a0ef5371413e6c404d7563342545aeb531c5c/assets/js/dashboard.js#L96 not set the new replaced string value to the var repoUrl.

The console error is:

TypeError: Cannot read property '0' of null
    at je.buildRecipeRepoUrl (dashboard.37bb0847d2441133ec9d.js:11)
    at je.n [as buildRecipeRepoUrl] (dashboard.37bb0847d2441133ec9d.js:1)
    at je.recipeUrl (dashboard.37bb0847d2441133ec9d.js:11)
    at je.n [as recipeUrl] (dashboard.37bb0847d2441133ec9d.js:1)
    at eval (eval at Xs (dashboard.37bb0847d2441133ec9d.js:1), <anonymous>:3:2558)
    at je.ie [as _l] (dashboard.37bb0847d2441133ec9d.js:1)
    at je.eval (eval at Xs (dashboard.37bb0847d2441133ec9d.js:1), <anonymous>:3:1167)
    at je.t._render (dashboard.37bb0847d2441133ec9d.js:6)
    at je.i (dashboard.37bb0847d2441133ec9d.js:1)
    at _r.get (dashboard.37bb0847d2441133ec9d.js:6)

at line https://github.com/moay/symfony-flex-server/blob/d07a0ef5371413e6c404d7563342545aeb531c5c/assets/js/dashboard.js#L100

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions