Maintainance: latest C# lang version, code style config fixes, nitrox…

… underscore patch name spell-check ignore, nitrox.analyzer as nuget (SubnauticaNitrox#2098)

.editorconfig

@@ -7,6 +7,10 @@ indent_style = space
 end_of_line = lf
 
 # ReSharper properties
+resharper_blank_lines_after_block_statements = 0
+resharper_braces_for_ifelse = required_for_multiline
+resharper_braces_redundant = false
+resharper_keep_existing_attribute_arrangement = true
 resharper_wrap_object_and_collection_initializer_style = chop_if_long
 
 [*.{proj, csproj, targets}]

Directory.Build.props

@@ -1,7 +1,7 @@
 <Project>
     <!-- Set default properties for all projects (can be overridden per project) -->
     <PropertyGroup>
-        <LangVersion>11</LangVersion>
+        <LangVersion>12</LangVersion>
         <Version>1.8.0.0</Version>
         <NitroxProject>false</NitroxProject>
         <TestLibrary>false</TestLibrary>
@@ -22,7 +22,7 @@
     <PropertyGroup Condition="$([System.Text.RegularExpressions.Regex]::IsMatch($(MSBuildProjectName), '^Nitrox.*$'))">
         <NitroxProject>true</NitroxProject>
     </PropertyGroup>
-    <PropertyGroup Condition="'$(NitroxProject)' == 'true' and '$(MSBuildProjectName)' != 'Nitrox.Analyzers'">
+    <PropertyGroup Condition="'$(NitroxProject)' == 'true'">
         <NitroxLibrary>true</NitroxLibrary>
     </PropertyGroup>
     <PropertyGroup Condition="'$(NitroxLibrary)' == 'true' and '$(MSBuildProjectName)' != 'NitroxModel' and '$(MSBuildProjectName)' != 'NitroxServer' and '$(MSBuildProjectName)' != 'Nitrox.BuildTool'">
@@ -47,15 +47,6 @@
         </When>
     </Choose>
 
-    <!-- Include our analyzer and code gen library to all Nitrox projects -->
-    <Choose>
-        <When Condition="'$(NitroxLibrary)' == 'true'">
-            <ItemGroup>
-                <ProjectReference Include="..\Nitrox.Analyzers\Nitrox.Analyzers.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
-            </ItemGroup>
-        </When>
-    </Choose>
-
     <!-- Include default project references to all other "Nitrox*" projects -->
     <Choose>
         <When Condition="'$(UnityModLibrary)' == 'true'">
@@ -68,6 +59,10 @@
                 <ProjectReference Include="$(SolutionDir)NitroxModel\NitroxModel.csproj">
                     <Name>NitroxModel</Name>
                 </ProjectReference>
+                <PackageReference Include="Nitrox.Analyzers" Version="*">
+                    <PrivateAssets>all</PrivateAssets>
+                    <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+                </PackageReference>
             </ItemGroup>
         </When>
     </Choose>