Optimized jsonsl_reset by removing code to reinitialize the stack #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stack items are initialized when used (pushed) and don't need to be zeroed out beforehand, except for the 'level' field, which can be initialized once at creation since it's never changed. This provides a significant performance boost when a context is used to parse large numbers of small JSON documents. (I've got a performance test that reads a file of 3.5M JSON objects, one per line.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack items are initialized when used (pushed) and don't need to be
zeroed out beforehand, except for the 'level' field, which can be
initialized once at creation since it's never changed.
This provides a significant performance boost when a context is used to
parse large numbers of small JSON documents. (I've got a performance
test that reads a file of 3.5M JSON objects, one per line.)