Skip to content

removed numpy.vectorize() wrappers #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2015

Conversation

CesiumLifeJacket
Copy link
Contributor

As they slow down the sigmoid functions considerably and unnecessarily. The network's SGD method runs several times faster with this simple modification.

directly, instead of wrapping them numpy's vectorize() function
@mnielsen
Copy link
Owner

mnielsen commented Jul 5, 2015

Thanks for making the changes. You look to have been quite thorough in modifying both network and network2.

With that said, I'll hold off on merging the pull request until I've got time to return to my work on the book - I'd rather the code in the book and on the repo don't get out of sync. In the meantime, I'll keep this pull request open.

mnielsen added a commit that referenced this pull request Aug 6, 2015
removed numpy.vectorize() wrappers
@mnielsen mnielsen merged commit bce65a6 into mnielsen:master Aug 6, 2015
@mnielsen
Copy link
Owner

mnielsen commented Aug 6, 2015

Looking through the code, I will also change spv to sp throughout. I'll make that commit separately.

@mnielsen
Copy link
Owner

mnielsen commented Aug 6, 2015

I've now made the spv -> sp change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants