-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MRG: Add support for data from NIRx Aurora 2021.9 software #9808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b09f3ab
Add support for data from NIRx Aurora 2021.9 software
rob-luke 2207522
Add support for data from NIRx Aurora 2021.9 software
rob-luke b38635c
More tests
rob-luke 26e7532
Flake
rob-luke cd35d4a
Bump testing version
rob-luke 9d3912a
Hash
rob-luke bfc3ed4
Update config.py
rob-luke 7ef4ce3
Update config.py
rob-luke c2639d3
TST: Fix tests
larsoner 4374a63
Merge remote-tracking branch 'upstream/main' into aurora20219
larsoner 093fab7
Add Eric to changelog
rob-luke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -200,15 +200,18 @@ def _test_raw_reader(reader, test_preloading=True, test_kwargs=True, | |
| # ranks should all be reduced by 1 | ||
| if test_rank == 'less': | ||
| cmp = np.less | ||
| else: | ||
| elif test_rank is False: | ||
| cmp = None | ||
| else: # anything else is like True or 'equal' | ||
| assert test_rank is True or test_rank == 'equal', test_rank | ||
| cmp = np.equal | ||
| rank_load_apply_get = np.linalg.matrix_rank(data_load_apply_get) | ||
| rank_apply_get = np.linalg.matrix_rank(data_apply_get) | ||
| rank_apply_load_get = np.linalg.matrix_rank(data_apply_load_get) | ||
| rank_apply_load_get = np.linalg.matrix_rank(data_apply_load_get) | ||
| assert cmp(rank_load_apply_get, len(col_names) - 1) | ||
| assert cmp(rank_apply_get, len(col_names) - 1) | ||
| assert cmp(rank_apply_load_get, len(col_names) - 1) | ||
| if cmp is not None: | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks @larsoner I am much happier having you make this internal change than me. Appreciate your effort |
||
| assert cmp(rank_load_apply_get, len(col_names) - 1) | ||
| assert cmp(rank_apply_get, len(col_names) - 1) | ||
| assert cmp(rank_apply_load_get, len(col_names) - 1) | ||
| # and they should all match | ||
| t_kw = dict( | ||
| atol=atol, err_msg='before != after, likely _mult_cal_one prob') | ||
|
|
@@ -280,7 +283,7 @@ def _test_raw_reader(reader, test_preloading=True, test_kwargs=True, | |
| assert set(raw.info.keys()) == set(raw3.info.keys()) | ||
| assert_allclose(raw3[0:20][0], full_data[0:20], rtol=1e-6, | ||
| atol=1e-20) # atol is very small but > 0 | ||
| assert_array_almost_equal(raw.times, raw3.times) | ||
| assert_allclose(raw.times, raw3.times, atol=1e-6, rtol=1e-6) | ||
|
|
||
| assert not math.isnan(raw3.info['highpass']) | ||
| assert not math.isnan(raw3.info['lowpass']) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is erroring (see below), as with my other comment are these standard tests an issue? Should I be adding each test file to this list?