Reduce pyvista viz test time #8246
Merged
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks like that shaved off 5 minutes, on this PR we get: compared to |
Contributor
Author
|
Very similar result with |
This reverts commit b1be32d.
larsoner
approved these changes
Sep 12, 2020
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
LGTM, feel free to merge @GuillaumeFavelier of travis reports reduced time and circle is okay
Member
|
It died because of #8241 so I'll go ahead and merge. Perhaps we should allow the viz tests to have more granularity in the reporting, since those are all sub-sub-module tests essentially... |
marsipu
pushed a commit
to marsipu/mne-python
that referenced
this pull request
Oct 14, 2020
* Specialize Travis * TST: Use no-op _add_mesh during testing * TST: Use SetVisibility(False) * Revert "Specialize Travis" [circle full] This reverts commit b1be32d.
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at reducing the time used by PyVista 3d viz tests. This is still a work in progress.
Try:
actor.SetVisibility(False)Closes #8242