-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MRG: Link picking informations in _LinkViewer #8112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
agramfort
merged 7 commits into
mne-tools:master
from
GuillaumeFavelier:timeviewer_link_picking
Aug 18, 2020
Merged
MRG: Link picking informations in _LinkViewer #8112
agramfort
merged 7 commits into
mne-tools:master
from
GuillaumeFavelier:timeviewer_link_picking
Aug 18, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I mitigated the issue with synchronized colors by just clearing the initial picked points. I don't have a real solution for now. |
Member
|
Show a union of all picked points on all linked brains at the time of linking, by removing then re-adding once linked? That way at least the first brain will have colors stay the same, and all picked points persist |
Contributor
Author
|
I'll build the union list and re-add then |
86 tasks
larsoner
approved these changes
Aug 18, 2020
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR links picking points in
_LinkViewerand adds apickingparameter tolink_brains().add_point()remove_point()Related to #7959 (comment)
It's an item of #7162