Skip to content

Conversation

@GuillaumeFavelier
Copy link
Contributor

@GuillaumeFavelier GuillaumeFavelier commented Aug 10, 2020

This PR links picking points in _LinkViewer and adds a picking parameter to link_brains().

  • Link add_point()
  • Link remove_point()
  • Synchronize points colors (mitigated)
  • Link the initial picked points

Related to #7959 (comment)
It's an item of #7162

@GuillaumeFavelier
Copy link
Contributor Author

I mitigated the issue with synchronized colors by just clearing the initial picked points. I don't have a real solution for now.

@larsoner
Copy link
Member

Show a union of all picked points on all linked brains at the time of linking, by removing then re-adding once linked? That way at least the first brain will have colors stay the same, and all picked points persist

@GuillaumeFavelier
Copy link
Contributor Author

I'll build the union list and re-add then

@GuillaumeFavelier GuillaumeFavelier changed the title WIP: Link picking informations in _LinkViewer MRG: Link picking informations in _LinkViewer Aug 17, 2020
@agramfort agramfort merged commit dc3bffd into mne-tools:master Aug 18, 2020
@agramfort
Copy link
Member

thx @GuillaumeFavelier

@GuillaumeFavelier GuillaumeFavelier deleted the timeviewer_link_picking branch August 19, 2020 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants