-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MRG, ENH: import code for optical imaging data from BOXY, fNIRS and fast signal #7717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
273 commits
Select commit
Hold shift + click to select a range
5d40535
debugged import function, plotting locations kinda works, dists calcu…
kylemath 17253b0
fixed name for return in utils.py
kylemath 31139cc
extra newline in boxy.py
kylemath eb1eb12
fixing newlines
kylemath bb4d804
removed call to findfiducials
kylemath d635296
removed mne calls
kylemath 36db210
revert to import mne to debug data
kylemath de69988
working data load and plot, needed to divide expected data by 16 for …
kylemath be3b6ec
pull sorce number from code
kylemath a216b4f
working plotting with rescale
kylemath 6985bc2
fixed import of coreg function
kylemath 2bab9aa
removed transform into fsaverage since it already was there
kylemath ab2b2de
working through bug plotting dig
kylemath 6d08ca4
working example
kylemath 62136ce
working version that loads in coordiantes and transforms correctly
kylemath d9eef81
fixed review comments
kylemath 38b8c3b
created gratton_emcp_epochs function in preprocessing/eog.py
kylemath 1fd2c3e
revert commit to master
kylemath 9f67db3
fix
kylemath fb0cbb3
revert
kylemath 1180a3d
fix
kylemath a08b170
space
kylemath 264ef06
Merge branch 'master' of https://github.com/kylemath/mne-python
kylemath b8a3319
initialize new branch with boxy.py file and folder in io with tests
kylemath 03ef3a7
fixing eog nonchange
kylemath a4882b2
fix
kylemath 4ac590d
fix
kylemath 8121cdb
rebase fix?
kylemath 3e1f72a
fix?
kylemath 1dfd09f
added dataset import information
kylemath 884c5c8
updated dataset stuff
kylemath 10fc5e7
correct hash from osf
kylemath 32adc37
working data load
kylemath 26c3c76
debuging loading file
kylemath 9a02fc8
debugged import function, plotting locations kinda works, dists calcu…
kylemath 753d66d
fixed name for return in utils.py
kylemath 5cef74d
extra newline in boxy.py
kylemath 0206d54
fixing newlines
kylemath 10c1612
removed call to findfiducials
kylemath 0be3184
removed mne calls
kylemath a7e8c11
revert to import mne to debug data
kylemath c6742a3
working data load and plot, needed to divide expected data by 16 for …
kylemath 840d78a
pull sorce number from code
kylemath a4ede9f
working plotting with rescale
kylemath 581a31c
fixed import of coreg function
kylemath d9240de
removed transform into fsaverage since it already was there
kylemath 0fd200f
working through bug plotting dig
kylemath e9af9cb
working example
kylemath 27edac2
working version that loads in coordiantes and transforms correctly
kylemath 74d6ebd
fixed review comments
kylemath f6f5cd2
Merge branch 'importBOXY' of https://github.com/kylemath/mne-python i…
kylemath 231355f
created gratton_emcp_epochs function in preprocessing/eog.py
kylemath 6673222
revert commit to master
kylemath 7c3988c
fix
kylemath 5f4eb9e
revert
kylemath 359ac72
fix
kylemath f6e9917
space
kylemath 4ee0ffc
rebase from import to fix pandas use
kylemath 788e06a
filetype now determined in RawBOXY and passed to _read_segment_file. …
kuziekj f51ecba
Merge branch 'master' of https://github.com/kylemath/mne-python
kuziekj a37a2e7
removed pdb
kylemath ecf71f0
Merge pull request #3 from kylemath/read_data_numpy2
kylemath a750db5
Merge branch 'master' into importBOXY
kylemath 8589a6c
new data file with more files
kylemath 85d3482
tested new dataset, added four new keys for four montages, and testin…
kylemath bef2e3f
pulling in source detector plotting temporarily
kylemath c6b14af
WIP trying to load multiple boxy files
kuziekj 9a10d19
Merge branch 'master' of https://github.com/kylemath/mne-python
kuziekj 007dfba
seems to be working...will find multiple files and combine all the da…
kuziekj 4654083
Merge branch 'master' into multiFile
kylemath e2de80d
Merge branch 'master' of https://github.com/kylemath/mne-python
kuziekj a9b24a4
boxy.py now takes a datatype arguments to return only AC, DC, or Ph data
kuziekj 532ce23
changed tutorial to plot montage a and b
kuziekj 2df06bb
Merge branch 'master' of https://github.com/kylemath/mne-python
kuziekj c558506
updated dataset P1 with arr
kylemath a59fc00
added new dataset with better variable names, removed look for .tol file
kylemath 8f2cffa
Merge branch 'master' into importBOXY
kylemath 0680c75
Merge branch 'importBOXY' into multifile
kylemath 98d0235
Merge branch 'master' into importBOXY
kylemath 3e62953
Merge branch 'importBOXY' into multiFile
kylemath 33134d3
made some changes based on comments. re-organised channels so lower w…
kuziekj 10ca706
pushed the wrong tutorial file, this should fix that
kuziekj 20c3808
Merge branch 'master' into importBOXY
kylemath 9fec7b3
Merge branch 'master' into multiFile
kylemath f8fdf06
Merge branch 'multiFile' of https://github.com/kylemath/mne-python in…
kylemath 3a617fb
style changes for flake8 on boxy.py
kylemath f81b16f
Merge branch 'master' of https://github.com/kylemath/mne-python
kuziekj dc62a03
tested parsed data set, channel numbers considered across all montage…
kuziekj 7fe90ff
blocks are now appended together, so data is now n channels by (m tim…
kuziekj 0f9ea82
Merge branch 'master' into importBOXY
kylemath 1175155
Merge branch 'importBOXY' into multiFile
kylemath d9391b2
Merge branch 'multiFile' of https://github.com/kylemath/mne-python in…
kylemath 6b4b4fa
Merge branch 'master' of https://github.com/kylemath/mne-python
kuziekj 9199c2a
added markers to indicate the end of each block. will also check for …
kuziekj 9a4be25
Merge branch 'master' into importBOXY
kylemath 0904a20
Merge branch 'importBOXY' into multiFile
kylemath a646c8a
Merge pull request #5 from kylemath/multiFile
kylemath 0a25db1
Merge branch 'master' of https://github.com/kylemath/mne-python
kuziekj 99dfe9e
marker channel kind is now stim instead of fnirs_raw, coords are no l…
kuziekj 4c392e5
Merge branch 'master' into importBOXY
kylemath 9197ee4
Merge branch 'importBOXY' into events_epochs
kylemath aa2cca2
Merge branch 'master' of https://github.com/kylemath/mne-python
kuziekj 9a83642
went through entire boxy tutorial to create and compare epochs
kuziekj 75b188d
Merge branch 'master' into importBOXY
kylemath 89b2963
Merge branch 'importBOXY' into events_epochs
kylemath a7cb72d
Merge branch 'events_epochs' of https://github.com/kylemath/mne-pytho…
kylemath 3cdba66
Merge branch 'master' of https://github.com/kylemath/mne-python
kuziekj b666512
added a few messages to print if markers are found or not, for each m…
kuziekj c08f328
Merge branch 'master' into importBOXY
kylemath 3fe8cad
Merge branch 'importBOXY' into events_epochs
kylemath dbf0e42
Merge branch 'events_epochs' of https://github.com/kylemath/mne-pytho…
kylemath 91ba501
updated dataset
kylemath 39deb72
marker times were off, had to change so first_samp and last_samp refe…
kuziekj be181a1
Merge branch 'master' of https://github.com/kylemath/mne-python
kuziekj b63e1d6
Merge pull request #6 from kylemath/events_epochs
kuziekj f897bd6
phase data will be unwrapped, detrended, and outliers removed
kuziekj b13d305
Merge branch 'master' into importBOXY
kylemath 7b7db20
Merge branch 'importBOXY' into phase_unwrap
kylemath a8706d8
Merge branch 'master' of https://github.com/kylemath/mne-python
kuziekj 93ce003
added conversion of phase to pico seconds
kuziekj 47c0565
initial push to create PR
kuziekj 7fbea60
fixed conflict with import dataset
kylemath 5563e58
Merge branch 'importBOXY' into phase_unwrap
kylemath 57bed45
Merge branch 'phase_unwrap' of https://github.com/kylemath/mne-python…
kylemath b051787
Merge branch 'importBOXY' into plot_all_montages
kuziekj 2e91987
tutorial will now combine montages and plot results of this combination
kuziekj 5c7b3c0
added wrong file to earlier commit
kuziekj 51be83c
working on adding two new data types, fnirs_ac and fnirs_ph
kuziekj 5ae1391
Merge branch 'master' into importBOXY
kylemath 51e4cca
Merge branch 'master' into phase_unwrap
kylemath 7ee083f
made test script in temporary dev folder
kylemath 9762f42
Merge branch 'importBOXY' into phase_unwrap
kylemath d8bfcc3
phase data will be unwrapped, detrended, and outliers removed
kuziekj 0de6fd5
added conversion of phase to pico seconds
kuziekj 375e51a
working on adding two new data types, fnirs_ac and fnirs_ph
kuziekj 78279f4
made test script in temporary dev folder
kylemath 8f16ba6
Merge branch 'phase_unwrap' of https://github.com/kylemath/mne-python…
kylemath 479558d
all plots except haemo should now be able to handle fnirs_ph, might n…
kuziekj 2c7f728
changed ph default scale
kylemath 38ea35d
Merge pull request #8 from kylemath/phase_unwrap
kuziekj 32f7cdc
removed some commented code
kuziekj d82520c
Merge branch 'master' into importBOXY
kylemath 1acdb02
reverted to existing tutorial
kylemath 035dd05
added sections to plot both AC and Ph data
kuziekj e3365bc
Merge branch 'master' of https://github.com/kylemath/mne-python
kuziekj 6b14593
fixed conflicts
kylemath a9fbc0c
Merge branch 'importBOXY' into plot_all_montages
kylemath bbbc0fe
changed time scale of ac data to 10 sec, replaced raw ac with haemo f…
kylemath a2042c7
now only plots AC haemo and phase data. Cleaned up formatting
kuziekj 443269c
Merge pull request #9 from kylemath/plot_all_montages
kuziekj 75fb2d2
plot_80 and boxy.py should now hopefully conform to pep8
kuziekj b110623
Merge branch 'master' into importBOXY
kylemath 25ffccc
Merge branch 'importBOXY' of https://github.com/kylemath/mne-python i…
kylemath ca38e68
Merge branch 'importBOXY' into clean_up
kylemath d68528c
fixed flake8 on boxy.py
kylemath f746b97
flake8 on other files
kylemath 070db84
removed dev folder
kylemath 2d7a2bb
a few more
kylemath 83dad8a
Merge pull request #11 from kylemath/clean_up
kylemath 47e5ac3
only combined montages plotted, scales have been adjusted, fixed chan…
kuziekj 495c80b
Merge branch 'master' into importBOXY
kylemath 8e5dddd
fixed conflict
kylemath 3d15b5c
in progress changes for testing
kuziekj 71cb997
Merge branch 'master' of https://github.com/kylemath/mne-python
kuziekj 84f9425
further changes for tests
kuziekj 03eb7b7
fixing conflicts
kuziekj 4c687a9
Merge pull request #16 from kylemath/clean_up
kylemath 4ffd552
fixed some apparent style issues, removed print statements added prev…
kuziekj 1b2ae92
more fixes, and removed forgotten print commands
kuziekj 70aa689
Merge branch 'master' into importBOXY
kylemath c2912bb
Merge branch 'importBOXY' of https://github.com/kylemath/mne-python i…
kylemath ff8ed41
Merge pull request #18 from kylemath/test_fixes
kylemath 033ac4e
Merge branch 'master' of https://github.com/kylemath/mne-python
kuziekj b498689
fixes for style and CI tests
kuziekj 13f3513
Merge pull request #19 from kylemath/more_test_fixes
kuziekj 3468f2b
start of making the tutorial a bit more simple
kuziekj 441697f
removed some plots to keep total under 20, and keep CI test happy
kuziekj 2a36c41
changed filter settings so an error is not returned
kuziekj d0e16a4
Merge pull request #20 from kylemath/simple_tutorial
kuziekj 19eab24
Merge branch 'master' into importBOXY
kylemath 42eadd8
Merge branch 'master' of https://github.com/kylemath/mne-python
kuziekj 3f85a7f
quick change to see if comment characters change html test
kuziekj 7bc8b2c
Merge pull request #22 from kylemath/tutorial_changes
kylemath af5224f
testing out a method of plotting hbo and hbr evoked
kuziekj 2a239d6
added more to difference evoked subplot, fixed a missing variable
kuziekj 61962a7
removed code for older plots
kuziekj 992029a
Merge remote-tracking branch 'upstream/master'
kuziekj 5d60033
merged recent changes, fixed conflicts, changed channel names
kuziekj 55d359d
missing blank line at end of eog.py
kuziekj 7384f8a
removed stray print statement
kuziekj 058df18
made sure files are sorted in the correct order
kuziekj 82a9f39
made changes for checklist
kuziekj 02e7f68
table of contents should now display properly
kuziekj aaa02a4
added references, and description, of boxy example dataset
kuziekj 46ef236
Merge pull request #23 from kylemath/tutorial_changes
kuziekj b628728
Merge remote-tracking branch 'upstream/master'
kuziekj 9ddc784
Merge branch 'master' into importBOXY
kuziekj 26df541
fixed merge conflicts
kuziekj e5eed6d
fixed style issue in plot_80
kuziekj 71b388e
addressed some checklist items
kuziekj 35df433
Merge pull request #25 from kylemath/checklist
kuziekj 34174cb
Merge remote-tracking branch 'upstream/master'
kuziekj 8ffa778
Merge branch 'master' into importBOXY
kuziekj 1630a26
Merge remote-tracking branch 'upstream/master'
kuziekj 7d86e43
Merge branch 'master' into importBOXY
kuziekj 1c7b8fe
updated info about boxy dataset
kuziekj 60d9499
Merge remote-tracking branch 'upstream/master'
kuziekj f3cd42e
Merge branch 'master' into importBOXY
kuziekj 6cebc86
Merge branch 'master' of https://github.com/kylemath/mne-python
kylemath c33212b
Merge branch 'master' into importBOXY
kylemath e788598
should now only read in boxy data file (#26)
kuziekj b6b8867
Merge remote-tracking branch 'upstream/master'
kuziekj 62ab96b
fix merge conflict
kuziekj 0132e09
Events from raw data file are added as annotations (#27)
kuziekj 6d72511
Merge remote-tracking branch 'upstream/master'
kuziekj 496898a
Merge branch 'master' into importBOXY
kuziekj 6672d7b
changed filenames to match testing data set (#29)
kuziekj 4046481
fixed merge conflict in eog.py
kuziekj 91b9012
fixed merge conflict in eog.py
kuziekj 95d8746
Merge remote-tracking branch 'upstream/master'
kuziekj c24013a
Merge branch 'master' into importBOXY
kuziekj 1063170
changes to make ci tests happy
kuziekj 22b3271
removed print statements and references to old dataset
kuziekj 67e1e83
Merge remote-tracking branch 'upstream/master'
kuziekj f425263
fixed merge conflict
kuziekj 34c5f7c
removed extra blank space
kuziekj fcaa8ff
Addressing reviewer comments (#30)
kuziekj a49059e
Merge branch 'master' into importBOXY
kuziekj 1813532
Merge remote-tracking branch 'upstream/master'
kuziekj 401a152
Merge branch 'master' into importBOXY
kuziekj a402c15
removed reference to fnirs_fd_phase
kuziekj a02c20c
removed reference to degrees for fnirs_fd_phase
kuziekj 32dfa3a
added line to return channel type
kylemath e91a2ea
working through review
kylemath ba1ba92
fixed coflict for rebase
kylemath 586c5d9
Merge branch 'master' of https://github.com/kylemath/mne-python
kylemath 336ed5c
fixed conflicts
kylemath c51bb0d
fixed indent bug
kylemath b6bd62e
adding new channel info throughout codebase
kylemath d8e8955
fixing merging errors
kylemath 07d96d1
Merge remote-tracking branch 'upstream/master' into importBOXY
larsoner 3e69ffc
FIX: Fix constants, reading, tests
larsoner cfdfa46
ENH: Efficient read
larsoner d0a6050
Update tutorials/io/plot_30_reading_fnirs_data.py
kylemath c96908d
Update tutorials/io/plot_30_reading_fnirs_data.py
kylemath 759f042
updated plot_30 tutorial boxy info
kylemath fbd9e79
typo
kylemath 983200d
FIX: SI units and backticks
larsoner 4398d12
FIX: Unit
larsoner 9f6beb5
FIX: Wording, comma
larsoner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| """fNIRS module for conversion to FIF.""" | ||
|
|
||
| # Authors: Kyle Mathewson, Jonathan Kuziek <kuziek@ualberta.ca> | ||
| # | ||
| # License: BSD (3-clause) | ||
|
|
||
| from .boxy import read_raw_boxy |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be good to use different color for the different returned types? I am thinking that users will start by simply plotting their returned signals and want to see that three types were returned, maybe different colors would make it easier to see the different types and notice the different patterns in each type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes sure, what other colours are available for phase and ac data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a standard in the literature (similar to how HbO is always red and HbR blue?), otherwise something pleasing (anything but fluro green please ;) )