Disable _TimeViewer when no time info is provided #7518
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
approved these changes
Mar 26, 2020
Contributor
Author
|
Please bear with me, I found a cleaner way based on |
Codecov Report
@@ Coverage Diff @@
## master #7518 +/- ##
===========================================
- Coverage 90.13% 36.58% -53.55%
===========================================
Files 452 452
Lines 82947 82958 +11
Branches 13113 13118 +5
===========================================
- Hits 74762 30351 -44411
- Misses 5350 50313 +44963
+ Partials 2835 2294 -541 |
larsoner
reviewed
Mar 26, 2020
| raise RuntimeError('This function requires pysurfer version ' | ||
| '>= 0.9') | ||
| if time_viewer: | ||
| time_viewer = _check_stc_time(stc, hemi) |
Member
There was a problem hiding this comment.
We don't want to always disable it, it controls more than time so can still be useful even if there is a single time point
Contributor
Author
|
Closing since #7520 suggests a better compromise instead of disabling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR locally tests the given brain and disables the
_TimeViewerwrapping when no time information is provided. For instance this happens inexamples/forward/plot_source_space_morphing.py.