MRG, ENH: Allow color reuse in clicking #7516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 tasks
Codecov Report
@@ Coverage Diff @@
## master #7516 +/- ##
==========================================
- Coverage 90.13% 90.13% -0.01%
==========================================
Files 453 453
Lines 82759 82813 +54
Branches 13062 13075 +13
==========================================
+ Hits 74597 74644 +47
- Misses 5343 5347 +4
- Partials 2819 2822 +3 |
GuillaumeFavelier
approved these changes
Mar 26, 2020
Contributor
GuillaumeFavelier
left a comment
GuillaumeFavelier
left a comment
There was a problem hiding this comment.
LGTM @larsoner
Member
|
thx @larsoner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow color reuse during picking with
_TimeViewer. It's an item of #7162.Probably worth adding to 0.20